Skip to content

Adding unknown extension callback to CertManager#7194

Merged
SparkiDev merged 3 commits intowolfSSL:masterfrom
anhu:CerManUnExtCb
Feb 8, 2024
Merged

Adding unknown extension callback to CertManager#7194
SparkiDev merged 3 commits intowolfSSL:masterfrom
anhu:CerManUnExtCb

Conversation

@anhu
Copy link
Copy Markdown
Member

@anhu anhu commented Jan 31, 2024

No description provided.

@anhu anhu self-assigned this Jan 31, 2024
@dgarske
Copy link
Copy Markdown
Member

dgarske commented Feb 1, 2024

Failing most tests with:

In file included from wolfcrypt/src/asn.c:200:
./wolfssl/internal.h:2635:5: error: unknown type name ‘wc_UnknownExtCallback’
 2635 |     wc_UnknownExtCallback unknownExtCallback;
      |     ^~~~~~~~~~~~~~~~~~~~~

@bandi13
Copy link
Copy Markdown
Contributor

bandi13 commented Feb 5, 2024

retest this please

@anhu anhu assigned wolfSSL-Bot and unassigned anhu Feb 5, 2024
@anhu anhu requested a review from wolfSSL-Bot February 5, 2024 23:47
@anhu anhu marked this pull request as ready for review February 5, 2024 23:48
Copy link
Copy Markdown
Member

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition. Please add a test case

@dgarske dgarske assigned anhu and unassigned wolfSSL-Bot Feb 6, 2024
@anhu anhu requested a review from dgarske February 7, 2024 21:51
@dgarske dgarske requested review from SparkiDev and removed request for dgarske February 7, 2024 22:18
@anhu anhu assigned wolfSSL-Bot and unassigned anhu Feb 7, 2024
@SparkiDev SparkiDev self-assigned this Feb 8, 2024
@SparkiDev SparkiDev removed the request for review from wolfSSL-Bot February 8, 2024 12:09
@SparkiDev SparkiDev merged commit 5b5f0ff into wolfSSL:master Feb 8, 2024
@anhu anhu deleted the CerManUnExtCb branch March 24, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants